Skip to content

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Jan 7, 2022

Add a new Documentation section for adding docs to the extension. This PR starts by adding docs on how to use the extension with VSCode Remote Development.

Resolves #82

@0xTim 0xTim requested review from svanimpe and adam-fowler January 7, 2022 15:05
Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of issues, nothing major.
Although I would hold back on suggesting we use the automatic setup until we have the devcontainer PR merged.

docs/README.md Outdated
@@ -0,0 +1,7 @@
# Swift for VSCode Documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need this file. It's just another click before someone gets to the documentation they want. The individual docs can go in the repository readme.

@0xTim 0xTim requested a review from adam-fowler January 10, 2022 17:06
Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one comment I think we are good now

@0xTim 0xTim merged commit 5b0963a into main Jan 11, 2022
@0xTim 0xTim deleted the remote-development-docs branch January 11, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide docs for VSCode Remote Development
2 participants